Prevent stale values of calculate_soil from leaking across threads #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another solution would be to move calculate_soil to be local to the |
RAbolafiaRosenzweig
approved these changes
Jul 19, 2024
|
ping on this PR, is the testing complete? |
Sorry for the delay. Our team is overwhelmed by a number of things but this test is on top of our list and will be done soon. |
|
@cenlinhe ping on this two-line change? |
|
I just merged this PR change. |
weiwangncar
pushed a commit
to wrf-model/WRF
that referenced
this pull request
Jan 29, 2025
TYPE: bug fix KEYWORDS: snow albedo, soil timestep, glacier heat capacity SOURCE: Cenlin He (NCAR) DESCRIPTION OF CHANGES: Bug fixes for the following three parts: 1. allow BATS snow albedo scheme for nighttime snow aging: NCAR/ccpp-physics#1091 2. fix the potential leakage caused by calculate_soil variable during parallelization: NCAR/noahmp#136 3. fix the missing of HCPCT output for glacier points: NCAR/noahmp#141 LIST OF MODIFIED FILES: only Noah-MP source code is changed in Noah-MP GitHub. phys/noahmp TESTS: The changes have passed the regression tests. RELEASE NOTE: Noah-MP bug fixes for (1) allowing BATS snow albedo scheme for nighttime snow aging, (2) the potential leakage caused by calculate_soil variable during parallelized run, (3) the missing of HCPCT output for glacier points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #135.